Skip to content

Creating Accessors, protecting variables and changing CPU state location access - #327

Open
EliasH-E wants to merge 18 commits into
anyaevostinar:mainfrom
EliasH-E:privatize_reorganize
Open

Creating Accessors, protecting variables and changing CPU state location access#327
EliasH-E wants to merge 18 commits into
anyaevostinar:mainfrom
EliasH-E:privatize_reorganize

Conversation

@EliasH-E

@EliasH-E EliasH-E commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread source/sgp_mode/hardware/CPUState.h Outdated
Comment thread source/sgp_mode/SGPHost.h Outdated
Comment thread source/sgp_mode/SGPHost.h Outdated
Comment thread source/sgp_mode/SGPWorld.h Outdated
Comment thread source/test/sgp_mode_test/unit_tests/SGPHost.test.cc Outdated
Comment thread source/test/sgp_mode_test/unit_tests/SGPHost.test.cc Outdated
// }
// }
// }

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changes here as host tests

Comment thread source/Organism.h

@anyaevostinar anyaevostinar left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to clean up

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.11570% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.03%. Comparing base (80c2445) to head (cad8cf3).

Files with missing lines Patch % Lines
source/sgp_mode/SGPWorldSetup.cc 10.86% 38 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   77.09%   77.03%   -0.07%     
==========================================
  Files         108      108              
  Lines       23155    23255     +100     
  Branches     1615     1622       +7     
==========================================
+ Hits        17852    17914      +62     
- Misses       5232     5268      +36     
- Partials       71       73       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants